search

threatstack / threatstack-ansible

Ansible for installing Threatstack Agent
https://www.threatstack.com
MIT License
23 stars 17 forks source link

Support for threatstack_hostname #52

Closed benpatterson closed 5 years ago

benpatterson commented 5 years ago

Starting a new PR with the associated commits in order to test on the Travis infrastructure, and put in some additional improvements while we're here.

benpatterson commented 5 years ago

I have to see what's up with travis failing, but with these changes, tests are passing "locally" aka on vagrant.

I have to put this down for now but hope to get back to it next week. Feel free to add your thoughts; otherwise I'll put in a cycle to sort out the travis failures.

benpatterson commented 5 years ago

Alright @sixth I think we are gtg.

CC @olhado in case he has comments/thoughts. Otherwise I'll plan on merging in the next day or 2.

sixth commented 5 years ago

LGTM

benpatterson commented 5 years ago

thx for the feedback and the PR itself :tada: merging