search

threefoldtecharchive / rivine

Blockchain technology for creating custom chains.
Apache License 2.0
22 stars 12 forks source link

add test-related Makefile targets back #624

Closed GlenDC closed 4 years ago

GlenDC commented 4 years ago

also removed two unit tests from the persistent pkg, one of the two tests failed, while fixing I realized that the code it was testing was only used in these two tests, hence deleting it all seemed like the more economical decision

fixes #623

robvanmieghem commented 4 years ago

Looks like the json _temp files are created in the persist/json.go/SaveJSon so not using the safeFile. Suprises me to see no real usage of this temp file though since that code just writes it to the temp file first and then to the normal one.

GlenDC commented 4 years ago

It it surprising indeed.

robvanmieghem commented 4 years ago

RemoveFile does not seem to be used either

GlenDC commented 4 years ago

I am sure there is more not used. Let's keep that for a new PR where I run some tooling to remove all unused code, that remained in the codebase from past changes by us or Sia.