search

thriftrw / thriftrw-go

A Thrift encoding code generator and library for Go
MIT License
100 stars 53 forks source link

thriftrw does not pass lint #303

Closed Raynos closed 7 years ago

Raynos commented 7 years ago 
raynos at raynos-ThinkPad-T440p  
~/gocode/src/go.uber.org/thriftrw on go-tag-support*
$ make lint; make test;
govet failed:
idl/parser_test.go:131: possible formatting directive in Error call
envelope/envelope_test.go:84: possible formatting directive in Error call
internal/plugin/flag_test.go:91: possible formatting directive in Error call
internal/plugin/flag_test.go:156: possible formatting directive in Error call
internal/plugin/flag_test.go:251: possible formatting directive in Error call
protocol/binary_test.go:80: possible formatting directive in Error call
protocol/binary_test.go:100: possible formatting directive in Error call
protocol/binary_test.go:682: possible formatting directive in Error call
gen/generate_test.go:76: possible formatting directive in Error call
gen/service_test.go:657: possible formatting directive in Error call
gen/struct_test.go:1511: possible formatting directive in Error call
gen/typedef_test.go:154: go.uber.org/thriftrw/gen/testdata/typedefs.I128 composite literal uses unkeyed fields
gen/typedef_test.go:173: go.uber.org/thriftrw/gen/testdata/typedefs.I128 composite literal uses unkeyed fields
gen/typedef_test.go:174: go.uber.org/thriftrw/gen/testdata/typedefs.I128 composite literal uses unkeyed fields
main_test.go:103: possible formatting directive in Error call
main_test.go:428: possible formatting directive in Error call
Makefile:74: recipe for target 'lint' failed
Raynos commented 7 years ago

Fixed in : https://github.com/thriftrw/thriftrw-go/pull/304

Raynos commented 7 years ago

Is now fixed.