thriftrw / thriftrw-go

A Thrift encoding code generator and library for Go
MIT License
101 stars 53 forks source link

Run more tests using the streaming implementation #549

Closed witriew closed 3 years ago

witriew commented 3 years ago

In the places where a FromWire(...) is invoked, call the corresponding streaming Decode(...) to check the populated Thrift object.

codecov[bot] commented 3 years ago

Codecov Report

Merging #549 (3ff1439) into dev (c06ddf6) will increase coverage by 0.62%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #549      +/-   ##
==========================================
+ Coverage   67.32%   67.94%   +0.62%     
==========================================
  Files         135      135              
  Lines       23531    23531              
==========================================
+ Hits        15842    15989     +147     
+ Misses       4593     4509      -84     
+ Partials     3096     3033      -63     
Impacted Files Coverage Δ
gen/internal/tests/containers/containers.go 56.88% <0.00%> (+0.28%) :arrow_up:
gen/internal/tests/typedefs/typedefs.go 68.11% <0.00%> (+0.62%) :arrow_up:
gen/internal/tests/services/services.go 61.30% <0.00%> (+0.81%) :arrow_up:
gen/internal/tests/structs/structs.go 63.74% <0.00%> (+2.31%) :arrow_up:
gen/internal/tests/unions/unions.go 67.90% <0.00%> (+3.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c06ddf6...3ff1439. Read the comment docs.