search

thriftrw / thriftrw-go

A Thrift encoding code generator and library for Go
MIT License
101 stars 53 forks source link

docs: Drop hub command from the RELEASE.md #585

Closed r-hang closed 1 year ago

r-hang commented 1 year ago

The current RELEASE.md relies on the hub command. I ran into authorization issues while trying to use hub for the release that were not easy to resolve. The problems I encountered are captured in a still open hub issue: https://github.com/github/hub/issues/2655. Given the extra steps required to work around and resolve this issue, I think it would be simpler to frame the release instructions in terms of local git commands and Github UI.

This change updates the RELEASE.md to replace hub commands with local git commands and Github UI instructions.

codecov[bot] commented 1 year ago

Codecov Report

Merging #585 (957045b) into dev (b9b2699) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #585   +/-   ##
=======================================
  Coverage   68.01%   68.01%           
=======================================
  Files         142      142           
  Lines       23878    23878           
=======================================
  Hits        16241    16241           
  Misses       4577     4577           
  Partials     3060     3060

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more