search

thriftrw / thriftrw-python

A Thrift encoding library for Python
MIT License
36 stars 10 forks source link

Type annotations can skip values #78

Closed abhinav closed 8 years ago

abhinav commented 9 years ago

Currently the grammar only supports type annotations in the form,

string (foo = "bar", baz = "qux")

The Thrift grammar allows for skipping the '= value' component of the annotation.

string (foo, bar = "qux")

Thrift defaults the value to the string "1" when the value is skipped.

We should probably support this too. Especially for the case where the only valid value for an annotation is "true".

abhinav commented 8 years ago

Oh this is a dupe of #84.