thsmi / sieve

Sieve Script Editor
GNU Affero General Public License v3.0
763 stars 59 forks source link

SIGTRAP on launch #938

Open Kreeblah opened 2 weeks ago

Kreeblah commented 2 weeks ago

Prerequisites

What happened?

I built from https://github.com/thsmi/sieve/commit/5879679ed8d16a34af760ee56bfec16a1a322b4e using npm install and gulp app:package-macos (with both npm and gulp sourced from Homebrew) and when I try to run the application bundle, it closes immediately without drawing a window. Running the sieve binary inside of it in the terminal just gets me this:

fish: Job 1, './sieve' terminated by signal SIGTRAP (Trace or breakpoint trap)

What did you expect to happen?

I'd expect the application to run.

Logs and Traces

crashlog.txt

I did some investigating, and this seems to start with commit https://github.com/thsmi/sieve/commit/9a03f6784d16640bdfccbe7dfc6a02097ece0d8f Prior commits run (but do nothing after server authentication succeeds and just get stuck showing "Connecting" forever), but that's the one that starts crashing on launch.

Screenshots

N/A

Which Version

Include information about your system, server and most important if it is about the app or webextension.

Aerion commented 9 hours ago

Same behavior, but upgrading electron to v33 made it work.

diff --git a/package.json b/package.json
index 0319fbf4..00637d07 100644
--- a/package.json
+++ b/package.json
@@ -10,7 +10,7 @@
   "devDependencies": {
     "bootstrap": "^5.2.3",
     "codemirror": "^5.65.4",
-    "electron": "^28.0.0",
+    "electron": "^33.0.0",
     "electron-packager": "^17.1.1",
     "eslint": "^8.29.0",
     "eslint-plugin-jsdoc": "^39.3.20",