search

thuliteio / seo

Official SEO integration for Thulite
https://seo.thulite.io
MIT License
0 stars 2 forks source link

Twitter summary card with large image #5

Closed h-enk closed 8 months ago

h-enk commented 1 year ago

Discussed in https://github.com/orgs/gethyas/discussions/423

Originally posted by **pensivedog** August 31, 2023 No matter what I try, my pages always have `` instead of ``. I have images set in front matter as an array, `images: ["img 1.jpg", img 2.jpg"]`. What am I doing wrong?

Fix check: https://github.com/gethyas/seo/blob/main/layouts/partials/hugo-seo/private/params/twitter.html#L5

pensivedog commented 1 year ago

The file https://github.com/gethyas/seo/blob/main/layouts/partials/hugo-seo/private/params/images.html does not follow the same lookup rules as the hugo internal template for twitter cards, which searches for image page resources with feature, cover, or thumbnail in their name when there is not images array in front matter.

It would be better if this module had a more robust way of searching for images.

It would be ideal if the front matter identifier for twitter card images could simply be configured in settings along with other seo module params.

h-enk commented 8 months ago

Fixed w/ new setup: Twitter Cards