thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.07k stars 2.51k forks source link

New swipe feature makes code blocks not horizontally scrollable #6297

Open TheLastProject opened 2 years ago

TheLastProject commented 2 years ago

Checklist

App version

6.302

Where did you get the app from?

F-Droid

Android version

12 (LineageOS for microG 19.1)

Device model

Fairphone 3

Steps to reproduce

  1. Receive an email with code block with longer length
  2. Try to scroll horizontall

Expected behavior

Can scroll horizontally through code block

Actual behavior

K-9 tries to move to the next email instead.

In this video I tried to move very softly. There is no difference between different levels of swiping force.

https://user-images.githubusercontent.com/1885159/189711982-42ba0437-5a46-4b64-b395-5fc6118a0197.mp4

(I know an email address is visible in the video, that's okay, it's just an alias and I'll replace it if it gets spam)

Logs

No logs, but I've included an anonymized version of the email I could trigger this on. I dragged this email into Inbox in Thunderbird to be able to confirm the anonymized version still triggers the bug in K-9 Mail but I'm sure you have your own tricks already :)

Re- org.fdroid.fdroid.debug Crash Report (#6).zip

cketti commented 2 years ago

The HTML doesn't make the WebView itself scroll horizontally. But the message contains an inner scrolling container. I'm not sure if/how we can detect that situation and disable the touch handling of the view pager in that case.

As a work-around you can swipe left/right using two fingers. The view pager will ignore all touch gestures involving more than one finger.

cketti commented 2 years ago

I don't know how to work around this issue without injecting JavaScript into the WebView. But for security reasons we disable JavaScript. And I don't think this bug is important enough to change that.

If someone has an idea how to deal with this, please let us know.