thunderbird / thunderbird-android

Thunderbird for Android – Open Source Email App for Android (fka K-9 Mail)
https://thunderbird.net/mobile
Apache License 2.0
11.02k stars 2.51k forks source link

Add support for daily build version codes #8411

Closed coreycb closed 3 weeks ago

coreycb commented 4 weeks ago

@kewisch I think this is pretty close. Can you take a look and let me know what you think? Things I can think of: 1) it may need a symlink update in build_unsigned after it pulls from git again, 2) Publish to Play Store step got skipped in my test run, 3) "Get release sha and notes" is getting garbage for the sha so I think I need to pass in the sha of HEAD.

I had to go with years since 2023 instead of years since 2024, because a leading zero caused failures. I think, for example, 02990040 might get interpreted as octal number.

kewisch commented 4 weeks ago

@kewisch I think this is pretty close. Can you take a look and let me know what you think? Things I can think of: 1) it may need a symlink update in build_unsigned after it pulls from git again, 2) Publish to Play Store step got skipped in my test run, 3) "Get release sha and notes" is getting garbage for the sha so I think I need to pass in the sha of HEAD.

I had to go with years since 2023 instead of years since 2024, because a leading zero caused failures. I think, for example, 02990040 might get interpreted as octal number.

Sorry, missed this comment while reviewing, was on mobile. Going with 2023 is of course fine. The symlink update is only really necessary for f-droid, so we don't need to do that on daily. Play store publish, let's be careful on that and only do so when we know everything else works. If you have it enabled in your environment, you might want to comment out the play store upload target in setup_release_automation and update the thunderbird_daily environment.

Re head sha, you can get that from github.sha or GITHUB_SHA. In beta/release we need to use the commit sha, but for daily we can use the one the build was started on.

coreycb commented 4 weeks ago

I believe all comments have been addressed. This is ready to review again.

coreycb commented 3 weeks ago

@kewisch this should be ready to review when you get some time