thunderbird / thunderbird-notifications

In-App notifications for Thunderbird
Mozilla Public License 2.0
0 stars 0 forks source link

Add GH action: convert yaml to json #9

Closed radishmouse closed 3 months ago

radishmouse commented 5 months ago

Closes #3 Closes #8

This PR:

Changes to the validate workflow were necessary since it is called from the convert workflow:

Tested locally using nektos/act:

Note: only partially tested on GitHub. (This PR includes an example JSON file that passes validation.) #13 has been created to address this.

radishmouse commented 4 months ago

One thing that's missing is that the resulting json files need to be commited/pushed to the repo. I'll update the GH action to include those steps

radishmouse commented 4 months ago

@malini I have tested this code heavily locally, but not on GitHub.

I have created #13 for testing on GH, but would feel more comfortable with at least one more set of eyes on the workflow code before I merge.

radishmouse commented 3 months ago

@MelissaAutumn I've added a python wrapper script for validation and moved the checks for yaml & json files from the workflow file to python. When you get a chance, please take a look?