Closed radishmouse closed 3 months ago
One thing that's missing is that the resulting json files need to be commited/pushed to the repo. I'll update the GH action to include those steps
@malini I have tested this code heavily locally, but not on GitHub.
I have created #13 for testing on GH, but would feel more comfortable with at least one more set of eyes on the workflow code before I merge.
@MelissaAutumn I've added a python wrapper script for validation and moved the checks for yaml & json files from the workflow file to python. When you get a chance, please take a look?
Closes #3 Closes #8
This PR:
Changes to the
validate
workflow were necessary since it is called from theconvert
workflow:validate
workflow reusable, but retains standalone functionalityvalidate
should_download
input tellsvalidate
to download the JSON artifacts produced during the GH actionis_valid
output contains the status of the validation (whether all json files were valid)Tested locally using nektos/act:
act pull_request
simulates a PRvalidate
workflow in standalone modeact push --artifact-server-path /tmp
simulates a pushconvert
workflow (which callsvalidate
before attempting to commit)Note: only partially tested on GitHub. (This PR includes an example JSON file that passes validation.) #13 has been created to address this.