search

tibudiyanto / jakarta-vax-availability

jakarta-vax-availability.vercel.app
100 stars 46 forks source link

Add GitHub Actions CI for linting + type checking #28

Closed resir014 closed 3 years ago

pveyes commented 3 years ago

cmiiw but doesn't next.js already do build-time type validation?

idk about lint, but given they recently launched eslint integration, we could probably just rely on vercel build

resir014 commented 3 years ago

@pveyes Unfortunately the Vercel build logs atm are invisible to everyone outside of @tibudiyanto. This gives a nicer overview of lint results + type checks without having to go to Theo's Vercel dashboard, and also helps for in case we need to add unit tests later.

pveyes commented 3 years ago

ah yeah, good point, forgot about logs

pveyes commented 3 years ago

btw should we disable (ignore) lint & typecheck in next build after #52 lands?

resir014 commented 3 years ago

@pveyes Yes, we should.