tibudiyanto / jakarta-vax-availability

jakarta-vax-availability.vercel.app
100 stars 46 forks source link

Add map and Typescript #9

Closed sonnylazuardi closed 3 years ago

sonnylazuardi commented 3 years ago

This PR will add

Please add Mapbox token from https://account.mapbox.com/access-tokens/ as env variable

NEXT_PUBLIC_MAPBOX_KEY=YOUR_MAPBOX_KEY

Result: https://jakarta-vax-availability-theta.vercel.app/map

https://user-images.githubusercontent.com/856609/124431677-3e538200-dda3-11eb-9cce-44dc43350a3e.mp4

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tibudiyanto/jakarta-vax-availability/EMwoNBtTVRUhuibvZgByoynqqp9a
✅ Preview: https://jakarta-vax-availability-git-fork-sonnylazua-a18747-tibudiyanto.vercel.app

angeloanan commented 3 years ago

Some results from the API returns an empty detail_lokasi field resulting in some vaccination sites not displayed in the map.

Should we handle this? (Relates to #8)

sonnylazuardi commented 3 years ago

Some results from the API returns an empty detail_lokasi field resulting in some vaccination sites not displayed in the map.

Should we handle this? (Relates to #8)

I handle this in filter function, is it not enough?

https://github.com/tibudiyanto/jakarta-vax-availability/pull/9/files#diff-696d52574dda2a3148dad50df0b171a8b883aacbe8f5e794c513d9ae16481530R85

sonnylazuardi commented 3 years ago

ah you mean how to display it if it isn't in the map? then i think need to go back and use the listing page (main page).

tibudiyanto commented 3 years ago

Amazing. What do i need to do to deploy these? Only API key? @sonnylazuardi

sonnylazuardi commented 3 years ago

Amazing. What do i need to do to deploy these? Only API key? @sonnylazuardi

Yes, only API key from https://account.mapbox.com/access-tokens/

env name: NEXT_PUBLIC_MAPBOX_KEY

tibudiyanto commented 3 years ago

I am not that familiar with typescript. @pveyes if you say its gucci imma hit the merge.

vercel[bot] commented 3 years ago

Someone is attempting to deploy a commit to a Personal Account owned by @tibudiyanto on Vercel.

@tibudiyanto first needs to authorize it.