search

tidymodels / agua

Create and evaluate models using 'tidymodels' and 'h2o'
https://agua.tidymodels.org
Other
21 stars 2 forks source link

add new arguments from tune #52

Closed simonpcouch closed 9 months ago

simonpcouch commented 9 months ago

PR 2/2, following up on tidymodels/tune#784. Will add some further context there.

I believe the censored regression mode isn't available in h2o anyway, so we'll never actually hit a point where a non-NULL eval_time makes it to this machinery.

The remaining changes, for metrics_info and params, are optional performance optimizations from recent versions of tune.

I believe all of the tune-related tests in this repo are skipped on CRAN. This would mean that tune goes in first, tuning with agua is broken for the meantime (as it already is), and then we submit agua once tune is ready to go.

simonpcouch commented 9 months ago

@qiushiyan, I'll request review from another on the team to make sure this is the approach we'd like to go with. Once we feel good about this route, I'll merge the tune PR, update the Remotes here, and then request your review here!

simonpcouch commented 9 months ago

Feel free to holler if you have any questions about this one, @qiushiyan! After merge, we'd ask that a new version of agua goes to CRAN once dev tune is sent to CRAN, some time in mid-January.

qiushiyan commented 9 months ago

Thanks @simonpcouch! I will submit agua once tune is ready.