Input check for `new_param_grid()` - Githubissues

tidymodels / dials

Tools for creating tuning parameter values

https://dials.tidymodels.org/

Other

114 stars 27 forks source link

Input check for `new_param_grid()` #354

Open hfrick opened 2 months ago

hfrick commented 2 months ago

Does this check ever get executed? Brought up by @EmilHvitfeldt https://github.com/tidymodels/dials/pull/351#discussion_r1768982827

https://github.com/tidymodels/dials/blob/555493bea7ae5f80c5a3375a9fe5580f7550e879/R/grids.R#L261-L265

topepo commented 2 months ago

No, I don't think so. Go ahead and remove it.