search

tidymodels / spatialsample

Create and summarize spatial resampling objects 🗺
https://spatialsample.tidymodels.org
Other
71 stars 5 forks source link

Re-export rsample helper functions #143

Closed mikemahoney218 closed 1 year ago

mikemahoney218 commented 1 year ago

Feature

It would be nice if spatialsample re-exported functions like get_rsplit(), and possibly analysis() and assessment(), so that spatialsample could be used on its own without also needing to load rsample (either via library() or ::).

If those functions were re-exported, it might also be useful to re-export a handful of other one-off utilities. I'm thinking rsample::reshuffle_rset() and maybe rsample::reverse_splits(), though I don't entirely remember the original use-case for that function.

hfrick commented 1 year ago

Or put rsample in Depends? 🤔

EmilHvitfeldt commented 1 year ago

I would suggest putting rsample in depends, the same way the recipes extension packages do with recipes

mikemahoney218 commented 1 year ago

I personally don't love putting rsample in Depends; while under the hood spatialsample is extending rsample, from the user's perspective you don't need to know that rsample exists in order to use spatialsample. I think that makes it different from recipes extension packages -- in those, it's reasonable to assume that you'll use functions from recipes in the course of normal usage (at least recipe()), while if you use spatialsample with the rest of tidymodels you'd never need to touch an rsample function. I also think it's non-desirable for all the non-spatial CV functions to get dumped into the environment, since it might suggest those are viable alternatives to the spatial CV functions.

github-actions[bot] commented 1 year ago

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.