search

tidyverse / tibble

A modern re-imagining of the data frame
https://tibble.tidyverse.org/
Other
682 stars 130 forks source link

chore: Drop fansi and import cli #1589

Closed olivroy closed 5 months ago

olivroy commented 5 months ago

to go with https://github.com/r-lib/pillar/pull/663

What is the implication for support inside knitr?

I saw this https://rpubs.com/krlmlr/pillar-focus

Could set_ansi_hooks() be baked in somehow?

Currently, there is no highlighting of code, except for hugodown and pkgdown. https://tibble.tidyverse.org/articles/tibble.html and https://www.tidyverse.org/blog/2023/08/teach-tidyverse-23/#conflict-resolution-in-the-tidyverse

Rmarkdown and Quarto show dull colors in output https://github.com/quarto-dev/quarto-cli/issues/3730

For example https://r4ds.hadley.nz/logicals#comparisons

Relates to https://github.com/tidyverse/tibble/issues/475

The PR doesn't break highlighting in pkgdown image

https://github.com/hadley/r4ds/issues/1027

krlmlr commented 5 months ago

Thanks!