search

tify-iiif-viewer / tify

TIFY is a slim and mobile-friendly IIIF document viewer.
GNU Affero General Public License v3.0
108 stars 27 forks source link

Next #107

Closed t11r closed 2 years ago

t11r commented 3 years ago

Ready to merge.

ipf commented 3 years ago

Not sure if I get it right, but according to https://iiif.io/api/presentation/2.1/#linked-data-context-and-extensions the context provided in your example is not correct

As the top level resource must have the IIIF Presentation API context,

t11r commented 3 years ago

The question is: Should TIFY refuse to display an otherwise valid document just because the @context string is invalid? It works in every other viewer.

ipf commented 3 years ago

Well, hard to decide. I cannot check the document, as it seems to have multiple issues or the validator is broken. The main task of a viewer is not validation - we could add this manifest to the test set, but cui bono? If you find any mechanism besides checking if @context is existing, go ahead. Otherwise I'd suggest to not load the document. What about adding a link to the vaidator with the invalid manifest to the error message?

t11r commented 3 years ago

It should not matter to us if the manifest is valid. If it contains data that TIFY can parse, it should be displayed. Maybe log a warning to the console.