tiiuae / sbomnix

A suite of utilities to help with software supply chain challenges on nix targets
125 stars 22 forks source link

Avoid double wrapping #123

Closed jonringer closed 3 weeks ago

jonringer commented 3 weeks ago

buildPythonPackage already accepts makeWrapperArgs which then get applied as part of the wrap python scripts shell hook

Cleans up the bin directory a bit:

# After
[23:20:01] jringer@jringer-5560-nixos ~/work/sbomnix (avoid-double-wrapping)
$ ls -a ./result/bin/
.nix_outdated-wrapped  .provenance-wrapped    .sbomnix-wrapped    nixgraph    repology_cli  vulnxscan
.nixgraph-wrapped      .repology_cli-wrapped  .vulnxscan-wrapped  nixmeta     repology_cve  
.nixmeta-wrapped       .repology_cve-wrapped  nix_outdated        provenance  sbomnix   

# Before
[23:20:55] jringer@jringer-5560-nixos ~/work/sbomnix (main)
$ ls -a ./result/bin/
..nix_outdated-wrapped-wrapped  .nix_outdated-wrapped  .repology_cve-wrapped  nixmeta       vulnxscan
..nixgraph-wrapped-wrapped      .nixgraph-wrapped      .sbomnix-wrapped       provenance    
..provenance-wrapped-wrapped    .nixmeta-wrapped       .vulnxscan-wrapped     repology_cli  
..sbomnix-wrapped-wrapped       .provenance-wrapped    nix_outdated           repology_cve  
..vulnxscan-wrapped-wrapped     .repology_cli-wrapped  nixgraph               sbomnix 
henrirosten commented 3 weeks ago

Thanks @jonringer