search

tijlleenders / ZinZen

Better together - an app to realize dreams together.
https://ZinZen.me
GNU Affero General Public License v3.0
45 stars 64 forks source link

Creating sub goal/budget causes error #2002

Closed Nicholas-Kipkoech closed 4 months ago

Nicholas-Kipkoech commented 4 months ago

Resolves #1987

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zinzen ✅ Ready (Inspect) Visit Preview Jul 30, 2024 6:16am
tijlleenders commented 4 months ago

I can only test this on the root level since breadcrumb seems to error... No idea if it is fixed. Maybe this PR shoukd be combined with fixing the breadcrumb.

Nicholas-Kipkoech commented 4 months ago

That would be great so that we can do it all at once

Nicholas-Kipkoech commented 4 months ago

@tijlleenders You can close the breadcrumb issue since it is fine now.

Nicholas-Kipkoech commented 4 months ago

Do we need to remove the lowest level breadcrumb? so that we can only remain with parent?

tijlleenders commented 4 months ago

@Nicholas-Kipkoech Please mention which issue(s) this PR closes.

Unless otherwise required, keep with one issue per PR.

Nicholas-Kipkoech commented 4 months ago

This PR will resolve #1987

tijlleenders commented 4 months ago

This PR will resolve #1987 and #1994

Please always add this to the PR description, like so:

Resolves #1987 
Resolves #1994

I doubt #1994 should be included, it is a modification on the working breadcrumb. We currently have a breadcrumb that is not functioning like in main.
Maybe you should make an new issue for the bug and reference that, if that bug doesn't exist already.

Nicholas-Kipkoech commented 4 months ago

@tijlleenders This goal will only resolve #1987 and #1994 will be an independent issue on its own.

tijlleenders commented 4 months ago

@tijlleenders This goal will only resolve #1987 and #1994 will be an independent issue on its own.

Again: please add it to the PR description.

tijlleenders commented 4 months ago

@Tushar-4781 Please review the code.