search

tikv / grpc-rs

The gRPC library for Rust built on C Core library and futures
Apache License 2.0
1.81k stars 253 forks source link

Remove dependency on boringssl-src if secure is not activated #536

Closed hug-dev closed 3 years ago

hug-dev commented 3 years ago

Hello 👋

In the README, it is written:

secure feature enables support for TLS encryption and some authentication mechanism. When you do not need it, for example when working in intranet, you can disable it by using the following configuration

However, even if it is disabled, boringssl-src will be included in the dependencies via grpcio-sys (see here).

Removing the need of compiling boringssl-src when the secure feature is disabled will make compilation faster and also easier for cross-compilation targets 👍

I am happy to have a go at it and try to modify the build.rs file to something that'd work.

BusyJay commented 3 years ago

Sure, feel free to send us your patch when ready!