search

tikv / jemallocator

Rust allocator using jemalloc as a backend
Other
332 stars 52 forks source link

set `--disable-stats` if `stats` feature is not enabled #82

Closed girlbossceo closed 1 month ago

girlbossceo commented 2 months ago

jemalloc defaults to enabling stats if --enable-stats is not present and --disable-stats was not set: https://github.com/jemalloc/jemalloc/blob/fa451de17fff73cc03c31ec8cd817d62927d1ff9/configure.ac#L1331-L1333

This issue was observed when we were building with stats and noticed the output of malloc_stats_print was basically the same.

Before:

image

After:

image
BusyJay commented 2 months ago

It's better to add it in the default feature list in this PR. This is still a breaking change for those rely on stats features without enabling it explicitly though.

girlbossceo commented 2 months ago

@BusyJay Added it to the default features

girlbossceo commented 1 month ago

@BusyJay Anything blocking this PR from being merged? The CI failure looks to be out of my control, the runner timed out. Everything else still passed.

BusyJay commented 1 month ago

Thanks!