tikv / migration

Migration tools for TiKV, e.g. online bulk load.
Apache License 2.0
36 stars 26 forks source link

[fix #317] fix metric #318

Closed zeminzhou closed 2 years ago

zeminzhou commented 2 years ago

Signed-off-by: zeminzhou zhouzemin@pingcap.com

What problem does this PR solve?

Issue Number: close #317

Problem Description: TBD

What is changed and how does it work?

Code changes

Check List for Tests

This PR has been tested by at least one of the following methods:

Side effects

Related changes

To reviewers

Please follow these principles to check this pull requests:

(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)

zeminzhou commented 2 years ago

image

zeminzhou commented 2 years ago

PTAL~

codecov[bot] commented 2 years ago

Codecov Report

Merging #318 (978b78d) into main (0077830) will decrease coverage by 0.1123%. The diff coverage is 0.0000%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/tikv/migration/pull/318/graphs/tree.svg?width=650&height=150&src=pr&token=7nmbrqKeWs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv)](https://codecov.io/gh/tikv/migration/pull/318?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) ```diff @@ Coverage Diff @@ ## main #318 +/- ## ================================================ - Coverage 61.0618% 60.9494% -0.1124% ================================================ Files 240 239 -1 Lines 20286 20348 +62 ================================================ + Hits 12387 12402 +15 - Misses 6779 6826 +47 Partials 1120 1120 ``` | Flag | Coverage Δ | | *Carryforward flag | |---|---|---|---| | br | `60.5320% <ø> (ø)` | | Carriedforward from [82c7912](https://codecov.io/gh/tikv/migration/commit/82c79122a02a93b3eeed2e373da298c06ad4736a?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | | cdc | `61.1422% <0.0000%> (-0.1654%)` | :arrow_down: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) to find out more. | [Impacted Files](https://codecov.io/gh/tikv/migration/pull/318?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [cdc/cdc/sorter/unified/backend\_pool.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9zb3J0ZXIvdW5pZmllZC9iYWNrZW5kX3Bvb2wuZ28=) | `66.9811% <ø> (ø)` | | | [cdc/cdc/sorter/unified/file\_backend.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9zb3J0ZXIvdW5pZmllZC9maWxlX2JhY2tlbmQuZ28=) | `33.3333% <0.0000%> (-0.4387%)` | :arrow_down: | | [cdc/pkg/retry/retry\_with\_opt.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL3BrZy9yZXRyeS9yZXRyeV93aXRoX29wdC5nbw==) | `90.9090% <0.0000%> (-4.5455%)` | :arrow_down: | | [cdc/cdc/kv/client.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9rdi9jbGllbnQuZ28=) | `83.8616% <0.0000%> (-2.1614%)` | :arrow_down: | | [cdc/cdc/sink/buffer\_sink.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9zaW5rL2J1ZmZlcl9zaW5rLmdv) | `79.4392% <0.0000%> (-1.8692%)` | :arrow_down: | | [cdc/cdc/server.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9zZXJ2ZXIuZ28=) | `35.1851% <0.0000%> (-0.8338%)` | :arrow_down: | | [cdc/cdc/http\_router.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9odHRwX3JvdXRlci5nbw==) | `81.4814% <0.0000%> (-0.5186%)` | :arrow_down: | | [cdc/cdc/capture/capture.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9jYXB0dXJlL2NhcHR1cmUuZ28=) | `0.0000% <0.0000%> (ø)` | | | [cdc/cdc/kv/region\_worker.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9rdi9yZWdpb25fd29ya2VyLmdv) | `79.5833% <0.0000%> (ø)` | | | [cdc/cmd/cdc/main.go](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NtZC9jZGMvbWFpbi5nbw==) | | | | ... and [4 more](https://codecov.io/gh/tikv/migration/pull/318/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | |
zeminzhou commented 2 years ago

/run-integration-test