tikv / migration

Migration tools for TiKV, e.g. online bulk load.
Apache License 2.0
36 stars 26 forks source link

[close #319] remove integration test `sink_tls` #320

Closed zeminzhou closed 2 years ago

zeminzhou commented 2 years ago

Signed-off-by: zeminzhou zhouzemin@pingcap.com

What problem does this PR solve?

Issue Number: close #319 Problem Description: TBD

What is changed and how does it work?

  1. remove integration test sink_tls
  2. rename cli_tls as tls1

Code changes

Check List for Tests

This PR has been tested by at least one of the following methods:

Side effects

Related changes

To reviewers

Please follow these principles to check this pull requests:

(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)

zeminzhou commented 2 years ago

PTAL~

codecov[bot] commented 2 years ago

Codecov Report

Merging #320 (f706b6c) into main (0077830) will decrease coverage by 0.1223%. The diff coverage is 0.0000%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/tikv/migration/pull/320/graphs/tree.svg?width=650&height=150&src=pr&token=7nmbrqKeWs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv)](https://codecov.io/gh/tikv/migration/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) ```diff @@ Coverage Diff @@ ## main #320 +/- ## ================================================ - Coverage 61.0618% 60.9395% -0.1224% ================================================ Files 240 240 Lines 20286 20330 +44 ================================================ + Hits 12387 12389 +2 - Misses 6779 6819 +40 - Partials 1120 1122 +2 ``` | Flag | Coverage Δ | | *Carryforward flag | |---|---|---|---| | br | `60.5320% <ø> (ø)` | | Carriedforward from [0077830](https://codecov.io/gh/tikv/migration/commit/0077830ed72c4772995c5dde442b88dcde46d1a2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | | cdc | `61.1279% <0.0000%> (-0.1797%)` | :arrow_down: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) to find out more. | [Impacted Files](https://codecov.io/gh/tikv/migration/pull/320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [cdc/cdc/sorter/unified/backend\_pool.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9zb3J0ZXIvdW5pZmllZC9iYWNrZW5kX3Bvb2wuZ28=) | `66.9811% <ø> (ø)` | | | [cdc/cdc/sorter/unified/file\_backend.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9zb3J0ZXIvdW5pZmllZC9maWxlX2JhY2tlbmQuZ28=) | `33.3333% <0.0000%> (-0.4387%)` | :arrow_down: | | [cdc/cdc/owner/status\_provider.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9vd25lci9zdGF0dXNfcHJvdmlkZXIuZ28=) | `14.5833% <0.0000%> (-6.0050%)` | :arrow_down: | | [cdc/cdc/kv/client.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9rdi9jbGllbnQuZ28=) | `84.0057% <0.0000%> (-2.0173%)` | :arrow_down: | | [cdc/cdc/sorter/unified/heap\_sorter.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9zb3J0ZXIvdW5pZmllZC9oZWFwX3NvcnRlci5nbw==) | `85.7142% <0.0000%> (-1.5307%)` | :arrow_down: | | [cdc/pkg/orchestrator/etcd\_worker.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL3BrZy9vcmNoZXN0cmF0b3IvZXRjZF93b3JrZXIuZ28=) | `77.3109% <0.0000%> (-1.2606%)` | :arrow_down: | | [cdc/cdc/server.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9zZXJ2ZXIuZ28=) | `35.1851% <0.0000%> (-0.8338%)` | :arrow_down: | | [cdc/cdc/http\_router.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9odHRwX3JvdXRlci5nbw==) | `81.4814% <0.0000%> (-0.5186%)` | :arrow_down: | | [cdc/cdc/sorter/unified/merger.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9zb3J0ZXIvdW5pZmllZC9tZXJnZXIuZ28=) | `68.2847% <0.0000%> (-0.3237%)` | :arrow_down: | | [cdc/cmd/cdc/main.go](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NtZC9jZGMvbWFpbi5nbw==) | `100.0000% <0.0000%> (ø)` | | | ... and [4 more](https://codecov.io/gh/tikv/migration/pull/320/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | |
zeminzhou commented 2 years ago

/run-integration-test