tikv / migration

Migration tools for TiKV, e.g. online bulk load.
Apache License 2.0
36 stars 26 forks source link

[close #348] support filter for key & value #349

Closed pingyu closed 1 year ago

pingyu commented 1 year ago

What problem does this PR solve?

Issue Number: close #348

Problem Description: Support filter for key or value

What is changed and how does it work?

Add metric "filter-out" (the test case is that all events were filtered out):

image

Code changes

Check List for Tests

This PR has been tested by at least one of the following methods:

Side effects

Related changes

To reviewers

Please follow these principles to check this pull requests:

(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)

codecov[bot] commented 1 year ago

Codecov Report

Merging #349 (c305708) into main (c340278) will decrease coverage by 0.1262%. The diff coverage is 63.7500%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/tikv/migration/pull/349/graphs/tree.svg?width=650&height=150&src=pr&token=7nmbrqKeWs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv)](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) ```diff @@ Coverage Diff @@ ## main #349 +/- ## ================================================ - Coverage 61.1272% 61.0011% -0.1262% ================================================ Files 240 240 Lines 20261 20357 +96 ================================================ + Hits 12385 12418 +33 - Misses 6758 6822 +64 + Partials 1118 1117 -1 ``` | [Flag](https://app.codecov.io/gh/tikv/migration/pull/349/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [br](https://app.codecov.io/gh/tikv/migration/pull/349/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `60.6802% <ø> (ø)` | | Carriedforward from [5e65388](https://app.codecov.io/gh/tikv/migration/commit/5e653888c0843d757aae16ac48fa0fe8ba162068?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | | [cdc](https://app.codecov.io/gh/tikv/migration/pull/349/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `61.1485% <63.7500%> (-0.1856%)` | :arrow_down: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) to find out more. | [Files Changed](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [cdc/cdc/kv/metrics.go](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9rdi9tZXRyaWNzLmdv) | `0.0000% <0.0000%> (ø)` | | | [cdc/cdc/processor/pipeline/keyspan.go](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9wcm9jZXNzb3IvcGlwZWxpbmUva2V5c3Bhbi5nbw==) | `0.0000% <0.0000%> (ø)` | | | [cdc/cdc/processor/pipeline/puller.go](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9wcm9jZXNzb3IvcGlwZWxpbmUvcHVsbGVyLmdv) | `0.0000% <0.0000%> (ø)` | | | [cdc/pkg/config/replica\_config.go](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL3BrZy9jb25maWcvcmVwbGljYV9jb25maWcuZ28=) | `63.2653% <0.0000%> (-5.6236%)` | :arrow_down: | | [cdc/pkg/util/ctx.go](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL3BrZy91dGlsL2N0eC5nbw==) | `76.4705% <0.0000%> (-12.1658%)` | :arrow_down: | | [cdc/cdc/kv/region\_worker.go](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9rdi9yZWdpb25fd29ya2VyLmdv) | `78.6885% <33.3333%> (-0.8949%)` | :arrow_down: | | [cdc/pkg/cmd/cli/cli\_changefeed\_update.go](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL3BrZy9jbWQvY2xpL2NsaV9jaGFuZ2VmZWVkX3VwZGF0ZS5nbw==) | `28.2051% <66.6666%> (+2.9877%)` | :arrow_up: | | [cdc/pkg/util/kv\_filter.go](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL3BrZy91dGlsL2t2X2ZpbHRlci5nbw==) | `91.6666% <91.6666%> (ø)` | | | [cdc/cdc/kv/client.go](https://app.codecov.io/gh/tikv/migration/pull/349?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#diff-Y2RjL2NkYy9rdi9jbGllbnQuZ28=) | `83.8848% <100.0000%> (-2.1382%)` | :arrow_down: | ... and [17 files with indirect coverage changes](https://app.codecov.io/gh/tikv/migration/pull/349/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv)
pingyu commented 1 year ago

/run-integration-test

pingyu commented 1 year ago

/run-pull-integration-test

purelind commented 1 year ago

/test ?

purelind commented 1 year ago

/run-integration-test

pingyu commented 1 year ago

/run-integration-test

zeminzhou commented 1 year ago

/run-integration-test