search

tikv / pd

Placement driver for TiKV
Apache License 2.0
1.06k stars 724 forks source link

*: remove unused code from participant.go #8782

Closed okJiang closed 2 weeks ago

okJiang commented 3 weeks ago

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

Release note

None.
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.62%. Comparing base (8bc9749) to head (6c6ebd4). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8782 +/- ## ========================================== - Coverage 75.62% 75.62% -0.01% ========================================== Files 461 461 Lines 72351 72300 -51 ========================================== - Hits 54719 54679 -40 + Misses 14134 14117 -17 - Partials 3498 3504 +6 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8782/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `75.62% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
okJiang commented 3 weeks ago

/retest

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [JmPotato,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline: