tikv / pd

Placement driver for TiKV
Apache License 2.0
1.06k stars 724 forks source link

etcd/path: change leaderPath/dcLocationPath/memberPath/allocalIDPath to absolute path #8789

Closed okJiang closed 4 days ago

okJiang commented 3 weeks ago

What problem does this PR solve?

Issue Number: Ref https://github.com/tikv/pd/issues/8582

What is changed and how does it work?

Check List

Tests

Release note

None.
okJiang commented 3 weeks ago

/retest

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 97.61905% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.35%. Comparing base (ec77762) to head (ca1da7e). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8789 +/- ## ========================================== + Coverage 75.19% 75.35% +0.15% ========================================== Files 459 460 +1 Lines 71299 71323 +24 ========================================== + Hits 53616 53745 +129 + Misses 14266 14183 -83 + Partials 3417 3395 -22 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8789/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8789/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `75.35% <97.61%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.

🚨 Try these New Features:

okJiang commented 3 weeks ago

/retest

okJiang commented 2 weeks ago

/retest

okJiang commented 4 days ago

/retest

ti-chi-bot[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [nolouch,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 4 days ago

[LGTM Timeline notifier]

Timeline:

okJiang commented 4 days ago

/retest