search

tikv / pd

Placement driver for TiKV
Apache License 2.0
1.06k stars 724 forks source link

client: genericize the batch controller #8793

Closed JmPotato closed 2 weeks ago

JmPotato commented 3 weeks ago

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Genericize the batch controller for the later reuse.

Check List

Tests

Release note

None.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 70.00000% with 51 lines in your changes missing coverage. Please review.

Project coverage is 75.68%. Comparing base (238d4d7) to head (ca06db6). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8793 +/- ## ========================================== + Coverage 75.64% 75.68% +0.03% ========================================== Files 461 461 Lines 72300 72315 +15 ========================================== + Hits 54690 54730 +40 + Misses 14107 14083 -24 + Partials 3503 3502 -1 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8793/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8793/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `75.68% <70.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.
JmPotato commented 2 weeks ago

/test pull-integration-realcluster-test

ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline: