search

tikv / pd

Placement driver for TiKV
Apache License 2.0
1.06k stars 724 forks source link

client: split the meta storage client #8822

Closed JmPotato closed 1 week ago

JmPotato commented 1 week ago

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Split the meta storage client from the client definitions.

Check List

Tests

Release note

None.
JmPotato commented 1 week ago

/cc @okJiang @rleungx @lhy1024

ti-chi-bot[bot] commented 1 week ago

@JmPotato: GitHub didn't allow me to request PR reviews from the following users: okJiang.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/tikv/pd/pull/8822#issuecomment-2482395024): >/cc @okJiang @rleungx @lhy1024 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 75.23%. Comparing base (40fe83e) to head (dac21a6). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8822 +/- ## ========================================== - Coverage 75.26% 75.23% -0.04% ========================================== Files 456 456 Lines 71608 71608 ========================================== - Hits 53898 53875 -23 - Misses 14281 14305 +24 + Partials 3429 3428 -1 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8822/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8822/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `75.23% <78.94%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.

🚨 Try these New Features:

ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [lhy1024,rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline: