*: independent the service discovery package

JmPotato commented 1 week ago

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Make the service discovery module of the client a separate package.

Check List

Tests

Unit test
Integration test

Release note

None.

JmPotato commented 1 week ago

/cc @rleungx @okJiang @lhy1024 PTAL

ti-chi-bot[bot] commented 1 week ago

@JmPotato: GitHub didn't allow me to request PR reviews from the following users: okJiang, PTAL.

Note that only tikv members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/tikv/pd/pull/8825#issuecomment-2484929453): >/cc @rleungx @okJiang @lhy1024 PTAL Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 87.50000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 75.29%. Comparing base (be4a366) to head (cfef0be). Report is 2 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #8825 +/- ## ========================================== + Coverage 75.24% 75.29% +0.05% ========================================== Files 458 459 +1 Lines 71300 71299 -1 ========================================== + Hits 53650 53688 +38 + Misses 14236 14213 -23 + Partials 3414 3398 -16 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8825/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8825/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `75.29% <87.50%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

okJiang commented 1 week ago

/retest

ti-chi-bot[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 4 days ago

[LGTM Timeline notifier]

Timeline:

2024-11-20 07:45:13.13037284 +0000 UTC m=+17700.750027351: :ballot_box_with_check: agreed by okJiang.
2024-11-25 03:43:23.818340062 +0000 UTC m=+435191.437994578: :ballot_box_with_check: agreed by rleungx.

JmPotato commented 4 days ago

/test pull-integration-realcluster-test

tikv / pd