tikv / pd

Placement driver for TiKV
Apache License 2.0
1.06k stars 724 forks source link

cluster: fix tso fallback due raft cluster did not stop tso service #8837

Closed lhy1024 closed 1 week ago

lhy1024 commented 1 week ago

What problem does this PR solve?

Issue Number: Close https://github.com/tikv/pd/issues/8836 ref #8477

What is changed and how does it work?

Check List

Tests

Release note

None.
lhy1024 commented 1 week ago

/check-issue-triage-complete

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.21%. Comparing base (76e3b43) to head (8d87f83). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #8837 +/- ## ========================================== - Coverage 75.24% 75.21% -0.03% ========================================== Files 456 458 +2 Lines 71608 71690 +82 ========================================== + Hits 53884 53925 +41 - Misses 14295 14323 +28 - Partials 3429 3442 +13 ``` | [Flag](https://app.codecov.io/gh/tikv/pd/pull/8837/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/tikv/pd/pull/8837/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv) | `75.21% <72.72%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=tikv#carryforward-flags-in-the-pull-request-comment) to find out more.

🚨 Try these New Features:

ti-chi-bot[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tikv/pd/blob/master/OWNERS)~~ [rleungx] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot commented 1 week ago

In response to a cherrypick label: new pull request created to branch release-8.5: #8838.