tikv / rust-rocksdb

rust wrapper for rocksdb
Apache License 2.0
276 stars 155 forks source link

Fedora 38 build issue #748

Open zamazan4ik opened 1 year ago

zamazan4ik commented 1 year ago

Hi.

I am trying to build the latest TiKV master branch (e159200cb2458c3744ffbab9bbf284e71f03b866) on Fedora 38 but get the following errors on build RocksDB component when I run make release: https://pastebin.com/TEitt25v (sorry for the errors in Russian).

The default GCC in Fedora 38 is GCC 13.1.1. I suggest at least removing -Werror flag from the build scripts to avoid such errors in the future.

tabokie commented 1 year ago

I see there're many real errors aside from warnings being converted to errors. We don't currently have gcc-11 CI so the testing is quite lacking. You are welcome to fix those issues in https://github.com/tikv/rocksdb.

JmPotato commented 1 year ago

I also encountered the same compile problem on the latest Arch Linux with gcc-13. After some investigation and attempts, it turned out the fastest way to solve this is to install and use the old version gcc like gcc-9 to compile like:

CC=gcc-9 make

Just adding -Werror flag won't fix the build since there are a lot of other incompatible problems with the newer compiler. Hope this would help you.

dveeden commented 9 months ago

https://github.com/facebook/rocksdb/commit/fb9a02589280024d1453a1a86bcea84e38c8172e will fix some of this.