search

tikv / rust-rocksdb

rust wrapper for rocksdb
Apache License 2.0
276 stars 155 forks source link

Fix skipping compaction filter logic when titan is enabled #776

Closed Connor1996 closed 9 months ago

Connor1996 commented 9 months ago

https://github.com/tikv/rust-rocksdb/pull/757 changes the interface of compaction filter, but Titan doesn't. When titan is enabled, it wraps the tikv compaction filter. But Titan only overrides the FilterV3 but UnsafeFilter. So every calling to UnsafeFilter would just call the default implement of the base compaction filter which turns out skipping the logic of tikv compaction filter.

This PR includes the interface changes on Titan side https://github.com/tikv/tikv/pull/16054