Set height on nested elements to avoid mutliple scrollbars

tilfinltd / aws-extend-switch-roles

Extend your AWS IAM switching roles by Chrome extension, Firefox add-on, or Edge add-on

https://chromewebstore.google.com/detail/aws-extend-switch-roles/jpmkfafbacpgapdghgdpembnojdlgkdl?utm_source=github

MIT License

1.32k stars 141 forks source link

Set height on nested elements to avoid mutliple scrollbars #207

Open fleaz opened 3 years ago

fleaz commented 3 years ago

Hey,

even with the latest version I was still struggling with #180 even on different screens and resolutions so I decided to create a small PR to make this awesome extension a tiny bit better :)

Best, Felix

Before

After

tilfin commented 3 years ago

@fleaz Could you tell me your OS and browser, screen scaling percent?

fleaz commented 3 years ago

OS: Arch Linux Browser: Chromium 91 Screen: 4K Scaling: Between 1,3x and 1,5x

tilfin commented 3 years ago

@fleaz I didn't reproduce this situation in my environment.

Scaling: Between 1,3x and 1,5x

Can you tell me how to set this up?

fleaz commented 3 years ago

I just talked to a colleague of mine who also uses this plugin and also has this issue and we found the root cause of this :)

This happens when you go to Settings -> Apperance and configure a Page Zoom higher than 100% (Mine was e.g. on 125% because I run a highDPI display and want things to be a bit bigger). In contrast to the normal zooming on a website with Ctrl+ +/- which only changes the page ocntent, the PageZoom you configure in the settings also has an effect on your browser extensions which causes the double scrollbar issue.

tilfin commented 3 years ago

@fleaz Thank you, I could recoginize it.

tilfin commented 3 years ago

Hmm, the height is not automatically expanded in my Windows environment.