search

tilfinltd / aws-extend-switch-roles

Extend your AWS IAM switching roles by Chrome extension, Firefox add-on, or Edge add-on
https://chromewebstore.google.com/detail/aws-extend-switch-roles/jpmkfafbacpgapdghgdpembnojdlgkdl?utm_source=github
MIT License
1.32k stars 141 forks source link

Broken images/background color #238

Closed nickjmv closed 2 years ago

nickjmv commented 2 years ago

Hi,

Since the last update, I've been experiencing issues with layout when adding a color AND a picture.

The color is present behind the image which makes it ugly. Also when removing the color from the config, a grey background is displayed behind the image.

Is this expected behaviour now or is this something that broke in the last release? Because before it was displaying only the image without color background.

tilfin commented 2 years ago

The original intent was applying the background color to the transparent image as it is now. However, for a long time it was implemented incorrectly and thus became a specification.

nickjmv commented 2 years ago

Ah okay, so right now this is how it was meant to be?

Then this can be closed, I'll modify my images ;)

tilfin commented 2 years ago

I'll fix not to apply gray to the background if the color is undefined. If a color is specified, apply it as is.

nickjmv commented 2 years ago

Ah that would be very cool of you!

tilfin commented 2 years ago

released v2.3.1