tilfinltd / aws-extend-switch-roles

Extend your AWS IAM switching roles by Chrome extension, Firefox add-on, or Edge add-on
https://goo.gl/0QFjow
MIT License
1.31k stars 140 forks source link

New UI change issues #340

Open temirlan-remington opened 3 months ago

temirlan-remington commented 3 months ago

Describe the bug When navigating to an account with the new UI change.

The switch role screen does not pre-fill the values. Screenshot 2024-03-27 at 11 38 07

To Reproduce Steps to reproduce the behaviour:

  1. Configure an account with role_arn value that will contain ! at the end
  2. Click on the plugin to switch account
  3. choose account from step 1
  4. You will be redirected to the Switch Role Page with All values empty (this is the issue)

Expected behavior When reproducing the issue the expected behaviour of step 4 should be: Switch role should be pre-filled with:

Screenshots Screenshot in description

Additional context

We use role_arn parameter and for Elevated account we add ! at the end so it will rediret to switch account page and someone has to remove the ! and switch the role (Just to avoid accidental use of elevated account)

Sample config

[profile Production] role_arn = arn:aws:iam::XXXXXXXXXXXXX:role/AdminRole! source_profile = identity-account

olleja-b commented 3 months ago

Having exactly the same issues.

yavuzb commented 3 months ago

Looks like the AWS UI now presents a completely empty form, instead of giving the user the chance to correct the error in the role name.

tilfin commented 3 months ago

AWS Extend Switch Roles is not involved in this Switch Role page. It merely emulates the action of clicking on the switch role history list on each AWS Management Console page. Therefore, it is up to AWS to fill in the parameters in the form when switching role is failed.

mehakkhanna02 commented 3 months ago

Having exactly the same issues.

Hiren-marakana commented 3 months ago

Having exactly the same issues.

temirlan-remington commented 3 months ago

@tilfin, would be the case that the plugin is not passing the right values?

Screenshot 2024-03-28 at 09 52 22

temirlan-remington commented 3 months ago

@tilfin when I try to fill the role values using URL https://signin.aws.amazon.com/switchrole?roleName=Admin!&account=123456797045

It keeps the values in the switch role page if they are invalid and not reset

Screenshot 2024-03-28 at 10 21 32
tilfin commented 3 months ago

@temirlan-remington When jumping from the AWS Management Console page, it is a POST request with a form body, which works differently from opening the URL with query parameters in a browser. If the POST request is invalid, the redirect will take you to the Switch Role form page. The process is handled by AWS, so AWS Extend Switch Roles cannot be involved.

tilfin commented 3 months ago

I have confirmed that the form fields are also not filled when the switch fails by clicking on the link in the Role history in the AWS Management Console page.

Please request AWS to revert the switch failure behaviour.

grimm26 commented 2 months ago

the weird thing is that it still works in one of my browsers

grimm26 commented 2 months ago

I found that I only hit this problem when using a web proxy. If you are affected and can try without a proxy, see if it suddenly starts working.