search

tiliado / nuvolaplayer

Nuvola Player - Tight integration of web-based media streaming services with your desktop
https://nuvola.tiliado.eu/
BSD 2-Clause "Simplified" License
334 stars 27 forks source link

Vapi patch directly in system ? #707

Closed SCOTT-HAMILTON closed 3 years ago

SCOTT-HAMILTON commented 3 years ago

https://github.com/tiliado/nuvolaplayer/blob/master/wscript#L611-L622

Is this actually patching the vapi files in user's system directly during build ?

Anyway I'm trying to package nuvolaplayer for Nixpkgs and I'm wondering if you could either give an option in the wscript to disable those patches or to support giving other vapi dirs.

jiri-janousek commented 3 years ago

Hello @SCOTT-HAMILTON, it doesn't patch system vapi files in-place, it creates a patched copy of some system vapi files as needed. I'll add --no-vapi-patch configure option.

jiri-janousek commented 3 years ago

Before considering packaging Nuvola, make sure you can package Vala-CEF 75.3770, which requires ancient patched CEF 75.3770 (the latest Chrome version is 88). I'd recommend waiting for #583.

SCOTT-HAMILTON commented 3 years ago

Ok, you're right, I better wait for the QtWebEngine port.

jiri-janousek commented 3 years ago

Fixed in master branch.