Describe the bug
If we upgrade soem, many functions in ec_motors.c will break. Anything that calls
ec_SDOwrite8()
ec_SDOwrite16()
ec_SDOwrite32()
will break, because legit distributions of soem do not provide these convenience functions. It seems they were added after downloading.
Expected behaviormcp either provides these convenience functions in its own code, for instance something that already needs to link against soem, like ec_motors.c, or stops using ec_SDOwrite[8,16,32]() in favor of ec_SDOwrite().
Environment info (please complete the following information):
PC hardware: any
OS: any
Software version b3bbc576c9b53eb886ba120f8c2f99ac1c0fd826
Additional context
I determined that soem doesn't provide ec_SDOwrite[8,16,32]() functions by looking at the state of the repo where the file header date first matches the one we have.
Describe the bug If we upgrade
soem, many functions inec_motors.cwill break. Anything that callsec_SDOwrite8()ec_SDOwrite16()ec_SDOwrite32()will break, because legit distributions ofsoemdo not provide these convenience functions. It seems they were added after downloading.To Reproduce Steps to reproduce the behavior:
./external_libs/soem/soem/ethercatcoe.cExpected behavior
mcpeither provides these convenience functions in its own code, for instance something that already needs to link againstsoem, likeec_motors.c, or stops usingec_SDOwrite[8,16,32]()in favor ofec_SDOwrite().Environment info (please complete the following information):
Additional context I determined that
soemdoesn't provideec_SDOwrite[8,16,32]()functions by looking at the state of the repo where the file header date first matches the one we have.https://github.com/OpenEtherCATsociety/SOEM/blob/6afd2f50cc4266527fc0e0b526e57338c2129fb6/soem/ethercatcoe.c
The newest version doesn't supply them either.