tim-hub / obsidian-bible-reference

Take Bible Study notes easily in the popular note-taking app Obsidian, with automatic verse and reference suggestions.
https://antioch.tech/obsidian-bible-reference/
MIT License
226 stars 41 forks source link

Plugin Settings Page is blank. #225

Closed Redster1 closed 1 week ago

Redster1 commented 1 week ago

The settings page for the plugin is blank except for the sponsor button.

image

When I open the console, this error message appears and seems relevant.

VM343 plugin:obsidia…ble-reference:12979 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'isFeatureEnabled')
    at BibleReferenceSettingTab.setUpVersionSettingsAndVersionOptions (VM343 plugin:obsidia…-reference:12979:50)
    at BibleReferenceSettingTab.display (VM343 plugin:obsidia…-reference:12848:10)

That seems related to this function here:

  setUpVersionSettingsAndVersionOptions() {
    let allAvailableVersionOptions = allBibleVersionsWithLanguageNameAlphabetically;
    const disableBibleAPI = FlagService.instance.isFeatureEnabled("disable-bible-api");  //  <-- This line specifically as the .isFeatureEnabled is flagged as having an error.
    if (disableBibleAPI) {
      allAvailableVersionOptions = allAvailableVersionOptions.filter((v) => {
        return v.apiSource.name !== BibleAPISourceCollection.bibleApi.name;
      });
    }

image

I probably wouldn't have worried about reporting this, but it switched Bible versions on me and I can't switch translations.

Happy to poke around and try to help in any way I can or provide more info.

Thanks so much for this awesome plugin. I love it. It's been super helpful as I've been working on a research project on the conscience.

tim-hub commented 1 week ago

Thanks, I can see it in one of my computers as well, let me fix it.

tim-hub commented 1 week ago

It is fixed in 3.1.2, can you have a try?

https://github.com/tim-hub/obsidian-bible-reference/releases/tag/3.1.2

tim-hub commented 1 week ago

@all-contributors add @Redster1 for bug

allcontributors[bot] commented 1 week ago

@tim-hub

I've put up a pull request to add @Redster1! :tada:

Redster1 commented 1 week ago

It's fixed! 🎉 Thank you so much!