timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

Add Gnome 3.8 support #113

Closed matejak closed 11 years ago

matejak commented 11 years ago

Shellshape claims that it is not compatible with Gnome 3.8, which is out for a while already, so it would be cool to have Shellshape available for it.

timbertson commented 11 years ago

I don't have 3.8 yet, any volunteers to test it?

If we're lucky, all that's needed is to update shellshape/metadata.json.

matejak commented 11 years ago

Let's say that I am the volunteer. I have tried the 0launch method you describe in the README, and I got a "problem" with the gnome-shell, I guess that is because of the version number.

Chosen implementations:
  Failed to select all required implementations

  Interface: http://gfxmonk.net/dist/0install/gnome-shell.xml
    No implementation selected (best was package:arch:gnome-shell:3.8.1-1:x86_64, but: None)
timbertson commented 11 years ago

Good point (and thanks for volunteering!).

I've committed changes to a new branch (3.8) to allow you to run it on 3.8 - if you do git fetch && git checkout origin/3.8 it should let you run it: https://github.com/gfxmonk/shellshape/tree/3.8

The change is pretty simple, you could just do it yourself if you prefer: https://github.com/gfxmonk/shellshape/commit/fa6231a0e63099ce2b0a2efa75d86361a5a488ec

offlineric commented 11 years ago

I've been using it with gnome 3.8 (from the gnome-team ppa) on Ubuntu 13.04 and everything but the keyboard shortcuts still works. Not sure if this is a problem with 3.8 itself or just ubuntu's packages for it.

JonathanReeve commented 11 years ago

I'm testing it with GNOME 3.8, too, also from the gnome-team ppa on Ubuntu 13.04, and I can confirm that it seems to work, although the keyboard shortcuts are broken.

matejak commented 11 years ago

I experience the same behavior - no keyboard shortcuts work. The Super key has emerged in 3.8 as a part of system keyboard shortcuts, so there certainly was a change under the hood involved: https://help.gnome.org/misc/release-notes/3.8/shortcuts.html.en

offlineric commented 11 years ago

I'd just like to add that changing the shortcuts with dconf-editor to use a different modifier key does not resolve the issue for me.

timbertson commented 11 years ago

OK, finally added code for the new keybindings API in 3.8, and pushed version 0.6 (via 0install and extensions.gnome.org, which might take a day or so to appear). Tested on a VM, the keybindings are now working fine.

matejak commented 11 years ago

I just point out that I still can't see shellshape appearing on extensions.gnome.org.

timbertson commented 11 years ago

Yeah, it seems to be taking a while stuck in review. I've poked the gnome-shell mailing list just in case their notifications are broken again.

tvannahl commented 11 years ago

I installed shellshape just yesterday via extensions.gnome.org. I am using Gnome 3.8.3-2 on Arch Linux.