timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

[Fedora 19, Gnome 3.8.3-3, Shellshape 0.6] "Shellshape Settings" Does Nothing #119

Closed mbsullivan closed 11 years ago

mbsullivan commented 11 years ago

Shellshape seems to work with Gnome 3.8.3-3. However, clicking on "Shellshape Settings" does nothing.

A terminal running 0launch ./shellshape-local.xml --replace gives the following when I click the button:

JS ERROR: !!!   Exception in callback for signal: activate
JS ERROR: !!!     message = '"imports.ui.main.shellDBusService._extensionsSerivce is undefined"'
JS ERROR: !!!     fileName = '"/home/mbsullivan/installers/shellshape/xdg/data/gnome-shell/extensions/shellshape@gfxmonk.net/indicator.js"'
JS ERROR: !!!     lineNumber = '100'
JS ERROR: !!!     stack = '"([object Object],[object GObject_Union])@/home/mbsullivan/installers/shellshape/xdg/data/gnome-shell/extensions/shellshape@gfxmonk.net/indicator.js:100
_emit("activate",[object GObject_Union])@/usr/share/gjs-1.0/signals.js:124
([object GObject_Union])@/usr/share/gnome-shell/js/ui/popupMenu.js:114
wrapper([object GObject_Union])@/usr/share/gjs-1.0/lang.js:213
([object GObject_Object],[object GObject_Union])@/usr/share/gnome-shell/js/ui/popupMenu.js:87
wrapper([object GObject_Object],[object GObject_Union])@/usr/share/gjs-1.0/lang.js:213
"'

Let me know if there's anything else I can provide! This is my first experience with gnome-shell or shellshape.

timbertson commented 11 years ago

Huh, so it does. Thanks for reporting, I'll take a look (I think I know what the cause is).

In the meantime, you can also get to the settings dialog by running gnome-shell-extension-prefs.

mbsullivan commented 11 years ago

I can verify that using gnome-shell-extension-prefs works!

timbertson commented 11 years ago

Fixed in 456b419d0b9b0b159740fae8a64676c63e3b4a92 (despite me mentioning the wrong issue ID there :/)