search

timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

gnome-shell 3.12 basic support #134

Closed tvannahl closed 10 years ago

tvannahl commented 10 years ago

In gnome-shell 3.12 the signals have been moved from MetaWindowActor to MetaWindow.

With this patch shellshape is starting in gnome-shell 3.12 but still seems to be unstable. Maybe the 3.12 development can be done in a working branch on master side, so more people are able to test and fix bugs?

This is pull-request is related to #132

timbertson commented 10 years ago

Thanks, I've included this in a new 3.12 branch. It looks like (if we're dropping support for 3.10 anyway) we can do without accessing the actor variable entirely, but perhaps you can verify if this still works after d2a5f87369c9e3da9fe0f447639f28a28f56df08

One minor nit: can you try to keep to the existing indentation? Most files are using tabs for indentation.

tvannahl commented 10 years ago

Yeah, removing the actor code works. Are you able to upload different versions (for different shell versions) to extensions.gnome.org?