search

timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

(allegedly) incompatible with GNOME 3.14 #144

Closed zacchiro closed 10 years ago

zacchiro commented 10 years ago

Heya, I've just upgrade to gnome-shell 3.14, and shellshape no longer works. According to the tweak tool "Extensions does not support shell version".

Could you port shellshape to the latest shell version?

Many thanks in advance!

PS this kind of breakage seems to be routine, unfortunately, and reappear at each shell upgrade. Is there a way to prevent them, or at least some mitigation like to port the extension in advance to the official release? That would give, say, to users following the GitHub project some chance to upgrade the extension ahead of time, and avoid breakages. Happy to test something in that direction, if you think it could help

timbertson commented 10 years ago

I've just added 3.14 to the declared compatibility on the github version (https://github.com/gfxmonk/shellshape/commit/561c21c1b27b015822e9f5ef450c6f2f27b82fda), but I've no idea if it will actually work. If you try it out, please let me know whether it works so I can do an official release.

Shell extensions work like firefox used to, where you're not allowed to declare that you're compatible with a version before it's released (it wouldn't really make much sense, since you're just guessing). And I unfortunately don't have the energy to immediately try out new releases, so it often falls to budding volunteers (like yourself? ;)) to test on the latest version. If anyone wants to test shellshape on prerelease versions in advance of a release, that'd be even neater :)

I guess I could just declare compatibility with 3.14 in an official release and then roll it back if people report problems, but I'm not sure if the gnome reviewers would like that...

zacchiro commented 10 years ago

Thanks!

I've tried it out and it does seem to work well.

I've got a couple of "Oh no, something went wrong" upon restarting gnome-shell, but they don't seem to be entirely correlated to shellshape --- and I got one also before re-enabling shellshape --- so it's probably something else.

I understand the compatibility problem (it just seems absurd to me that the extensions interface assumes future incompatibility and doesn't allow to declare stuff like ">= 3.14", but that's clearly not up to you :-)). I'd be happy to test extensions releases in advance, but I do not have an easy way to test gnome-shell releases before they are officially released :-/

timbertson commented 10 years ago

Thanks for testing :) I've submitted a new version (to extensions.gnome.org) declaring compatibility with 3.14.