search

timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

workaround for typescript 1.1 incompatibility #147

Closed benalbrecht closed 10 years ago

benalbrecht commented 10 years ago

the build tool currently installs the latest typescript version. compilation with typescript 1.1 (released on oct 6) fails with to the following error:

$ tools/gup compile
gup  compile
gup    schemas/inputs
gup    shellshape/all
gup      shellshape/extension.js
gup        shellshape/_sources
../src/workspace.ts(434,10): error TS2365: Operator '===' cannot be applied to types 'Window' and 'Window'.
gup      Target `shellshape/extension.js` failed with exit status 1
gup    Target `shellshape/all` failed with exit status 2
gup  Target `compile` failed with exit status 2

this patch forces the installation of an older typescript version which works correctly

timbertson commented 10 years ago

Thanks. Any references for what changed the === operator in ts? I can't see any mention of that sort of thing in the 1.1 release notes...

benalbrecht commented 10 years ago

No idea, I have no experience with typescript.

timbertson commented 10 years ago

Ahh cool, fwiw it was actually a legitimate complaint (I was comparing objects of different types, although both types are confusingly named "Window"). Fixed in 3cd2ce1183be642f084464f67e69bfa42ce1d80b