Closed duffolonious closed 9 years ago
Thanks for the report. This code was changed (in the opposite direction) for 3.16 compatibility, because get_outer_rect has been removed.
So it sounds like the best fix is to just orphan gnome 3.10 on the commit 55423e1b45c2903e6db0a6f74ddc278e36758edd. I'll make a branch for this, and drop 3.10 compatibility from the master branch.
get_frame_rect() does not exist in Gnome 3.10: //start snip (gnome-shell:11152): Gjs-WARNING **: JS ERROR: TypeError: this.meta_window.get_frame_rect is not a function Window.prototype.rect@/home/duff0097/.local/share/gnome-shell/extensions/shellshape@gfxmonk.net/extension.js:1853 //end snip
This pactch fixes the problem: //start snip
//end snip
Dunno if there is a right way to deal with this - perhaps check gnome version? or just test to see if the function is defined? Nonetheless, without this change nothing appears to work.