timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

Provide gup script that installs extension system-wide #198

Open Lesik opened 7 years ago

Lesik commented 7 years ago

Hey,

for packaging this extension, it would be useful to have a gup script that installs system-wide.

I have created PR #195 for this, but I noticed that the resulting install has two problems:

Please fix these by providing a gup target that installs to the correct system path, respecting $PREFIX, and only contains data, lib, locale, extension.js, metadata.json, prefs.js and shellshape.pot, like the official zip you offer on GNOME's extension site.

timbertson commented 7 years ago

It's probably easier to make a plain install script rather than using gup - that way you can use:

gup --clean --metadata --force <target>

(doing that from inside a gup target would lead to sad times)

I've just moved the gup directory out of shellshape in b0d3d3f5f5b9a390fda607986db28facb4e21d8b.

using cp -L (or --dereference) should fix the symlink issue?

There are a few other files that are excluded in zip.gup, but do they really matter? You could always build the zip then just extract to your destination it if you're worried about the extra files, since the zip is the thing that I care about as maintainer.