search

timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

GNOME 3.30 support #215

Open neynt opened 6 years ago

neynt commented 6 years ago

GNOME 3.30 changed a bunch of APIs. I got Shellshape to work again at a basic level in my fork (https://github.com/neynt/shellshape), but it now seems to be ignoring the top bar when tiling so window title bars end up behind it. ... might try to fix that at some point but it works for me in the meantime, so just posting this in case anyone else has become irredeemably dependent on this extension.

mattrbrousseau commented 5 years ago

Did you happen to fix the issue that you were having with the top bar? I'm also one of those who have become irredeemably dependent on shellshape...

neynt commented 5 years ago

Unfortunately not. I've been using Hide Top Bar which makes life tolerable in the meantime.

esauvisky commented 5 years ago

@neynt, is your fork the only 3.30 working version so far?

Looking at the Network Insights, looks like there was a fork from @neilw4 with some newer commits, but there's no mention of 3.30 support, maybe he can reach out here :grin:

I'd love to give it a go and keep the extension alive, but I have absolutely zero experience with TypeScript. Perhaps I should take the challenge to learn something new? :thinking:

Also, yeah me too, irredeemably dependent on tiling windows. Wouldn't mind another extension, problem is shellshape was the only solution I ever found that actually just ... worked!

neilw4 commented 5 years ago

@esauvisky I believe @neynt 's fork is the only version working with 3.30. I tried to base mine on it but it's not backwards compatible with <3.30. It shouldn't be too tricky to modify https://github.com/neynt/shellshape/commit/b1c3b8bb06474e1abd3058b973b69dd09355fd31 to work with both versions - and it's a good introduction to TypeScript (this is also my first TS project and it's really not too scary - I'm happy to give advice and review PRs). Feel free to fork my code or send PRs.