timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

conky window gets tiled #73

Closed timbertson closed 12 years ago

timbertson commented 12 years ago

but it shouldn't!

If you run conky, please send (or paste) the output of:

$ xprop

(and then click the conky window when your cursor turns to a crosshair)

yellowhat commented 12 years ago

This is mine:

XKLAVIER_STATE(INTEGER) = 0, 0 WM_STATE(WM_STATE): window state: Normal icon window: 0x0 _NET_WM_ALLOWED_ACTIONS(ATOM) = _NET_WM_ACTION_MOVE, _NET_WM_ACTION_RESIZE, _NET_WM_ACTION_FULLSCREEN, _NET_WM_ACTION_MINIMIZE, _NET_WM_ACTION_MAXIMIZE_HORZ, _NET_WM_ACTION_MAXIMIZE_VERT, _NET_WM_ACTION_CHANGE_DESKTOP, _NET_WM_ACTION_CLOSE, _NET_WM_ACTION_ABOVE, _NET_WM_ACTION_BELOW _NET_WM_DESKTOP(CARDINAL) = 4294967295 _NET_WM_STATE(ATOM) = _NET_WM_STATE_SKIP_PAGER, _NET_WM_STATE_SKIP_TASKBAR, _NET_WM_STATE_BELOW, _NET_WM_STATE_STICKY _WIN_LAYER(CARDINAL) = 0 _MOTIF_WM_HINTS(_MOTIF_WM_HINTS) = 0x2, 0x0, 0x0, 0x0, 0x0 _NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL WM_PROTOCOLS(ATOM): protocols
WM_NAME(STRING) = "Conky (yellowhat)" WM_LOCALE_NAME(STRING) = "it_IT.UTF-8" WM_CLASS(STRING) = "Conky", "Conky" WM_HINTS(WM_HINTS): Client accepts input or input focus: False Initial state is Normal State. WM_CLIENT_MACHINE(STRING) = "yellowhat" WM_COMMAND(STRING) = { "conky" }

yellowhat commented 12 years ago

Setting "own_window_type dock" seems to works but it stay on left side although I set it on top_right

timbertson commented 12 years ago

Can you confirm whether this commit fixes it?

yellowhat commented 12 years ago

Did you update on https://extensions.gnome.org/extension/294/shellshape/?

timbertson commented 12 years ago

Not yet, you'll have to run it from a git checkout to test (or wait until the next release, shouldn't be too long - I don't mind either way)

yellowhat commented 12 years ago

I think I will wait for next release

MeisterP commented 12 years ago

For me, the conky window still gets tiled.

It works like intended if I change own_window_hints below,sticky,skip_taskbar,skip_pager,undecorated to own_window_hints above,sticky,skip_taskbar,skip_pager,undecorated.

There seems to be a difference in the handling of _NET_WM_STATE_ABOVE and _NET_WM_STATE_BELOW

timbertson commented 12 years ago

Ahh, silly javascript. It should be fixed in 96ac458c19a069b0b5f181f3a0a4e224a94c3b40, but I'll do further testing to make sure and then make a new minor release with this fix.

timbertson commented 12 years ago

Hmm, you know what? meta_window doesn't actually expose below as a property, despite exposing above. So I sort of assumed that would work, but it does nothing.

Having said that, I installed conky myself and can't get shellshape to tile it if I try. Do you have a particularly odd setup? I'm getting the following from xprop:

_NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_DESKTOP

So it registers as something shellshape can't tile for that reason, regardless of the above / below sticky state.

MeisterP commented 12 years ago

Here it is _NET_WM_WINDOW_TYPE(ATOM) = _NET_WM_WINDOW_TYPE_NORMAL with own_window_type normal in my conkyrc (which is the default value according to http://conky.sourceforge.net/config_settings.html).

The conky window doesn't get tiled if I set own_window_type to desktop in conkyrc. The problem here is that own_window_type desktop doesn't work correct if you set org.gnome.desktop.background show-desktop-icons to true with gnome-tweak-tool, dconf-editor or gsettings.

The conky settings are sometimes really hackish and depend on a lot of different factors.

Maybe you could match the WM_CLASS(STRING) = "Conky", "Conky" which is set by own_window_class in the conkyrc and defaults to "Conky" (see http://conky.sourceforge.net/config_settings.html)?

timbertson commented 12 years ago

Ok, finally reproduced (and fixed, after a disorienting attempt in which I tiled only the conky window). You're right, a wm_class blacklist was the way to go. I want to knock down issue #76 in the next few days because it's personally bugging me, then I'll release a new version on extensions.gnome.org.

MeisterP commented 12 years ago

I can confirm that conky gets properly ignored now. Thanks for fixing.