search

timbertson / shellshape

tiling window manager extension for gnome-shell
http://gfxmonk.net/shellshape/
Other
396 stars 38 forks source link

gnome-shell 3.6 #99

Closed MeisterP closed 12 years ago

MeisterP commented 12 years ago

Some changes to work with gnome-shell 3.6

timbertson commented 12 years ago

Thanks! So can you confirm that this works in 3.6 now? I haven't been able to test it myself yet sadly, my F18 VM won't boot.

MeisterP commented 12 years ago

Yes, it works on 3.6. I am not sure if it works on 3.4 without icon_type: (St.IconType.SYMBOLIC). Maybe you need to add something like

if (this._shellVersion == "3.4") {
        this.icon = new St.Icon({
            icon_type: (St.IconType.SYMBOLIC)
            ,style_class: 'system-status-icon'
        })
} else {
        this.icon = new St.Icon({
            style_class: 'system-status-icon'
        });
}
timbertson commented 12 years ago

Yeah, I think it's fine without it - after merging your commit I tried it out on 3.4.2, it worked fine without the icon_type property. I remember when I was trying to figure out the symbolic icon stuff it was very much trial and error, so I'm not surprised that some of it wasn't necessary in the end.