feat(swirly-renderer-next): next gen renderer

timdp / swirly

A marble diagram generator.

https://swirly.dev

MIT License

117 stars 3 forks source link

feat(swirly-renderer-next): next gen renderer #41

Open demensky opened 2 years ago

demensky commented 2 years ago

[x] Drawing text with <path />. No need to worry about the presence of the font.
[x] Dynamic calculation of stream title width.
[x] Dynamic calculation of operator width. <foreignObject /> is not used.
[x] Lack of sub pixel coordinates. Clearer display.
[x] Rendering without browser APIs. Can be easily run in Node.js.
[x] complete & error now have the same radius as next. But complete & error become larger if next overlaps them. Just like here.
[x] Built-in dark theme!

The parser is not yet able to handle such a case (or I did not understand how):

[x] Has no restriction on nesting of streams.
[x] Nested streams in the operator.

Closes: timdp/swirly#39 Closes: timdp/swirly#40

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
swirly	✅ Ready (Inspect)	Visit Preview	Nov 15, 2022 at 10:40AM (UTC)

timdp commented 2 years ago

I was gonna suggest creating a PR so thanks! I'll do an in-depth review asap.

demensky commented 2 years ago

This is not the final revision yet. I wanted to discuss with you the reorganization of styles. My suggestion is to reduce the ability to change styles from within the diagram itself, leaving only the required styles (such as observableDistanceX). Styling will be done when rendering, similar to markdown. This will avoid unnecessary customization.

demensky commented 2 years ago

What are your suggestions for improving this implementation?

demensky commented 1 year ago

Sorry for not being able to interest you.

timdp commented 1 year ago

No, I'm the one who should be sorry.

You've raised a legitimate concern and proposed a solution. More people in OSS should do that.

However, reviewing this is quite a daunting task to me. I was going to start with a few high-level considerations, but while I genuinely do appreciate your input, I can't say I'm looking forward to putting in the raw effort.

Combined with my tendency to drift in and out of specific projects, I'm unable to give you a timeline. But rest assured, this is sitting in my inbox and I'm very much aware of it. That's the best I can do right now.